feat: Windows support (wt.exe backend, build tags, CI + release)#62
Open
samarthya-gupta1 wants to merge 3 commits into
Open
feat: Windows support (wt.exe backend, build tags, CI + release)#62samarthya-gupta1 wants to merge 3 commits into
samarthya-gupta1 wants to merge 3 commits into
Conversation
Adds native Windows support across the binary, spawn layer, release pipeline, and install docs: - Build-tag iterm/terminal/warp/ghostty (and their tests) //go:build darwin so the tree compiles cleanly under GOOS=windows. - Split spawner into spawner_darwin / spawner_windows / spawner_unix variants sharing the Backend enum + POSIX ShellQuote. Windows defaults to BackendWT. - New internal/wt package: Windows Terminal spawn backend via `wt.exe -w 0 nt -d <cwd> --title <t> powershell.exe -NoExit -Command <ps>` with env-prefix injection (`$env:NAME='value';`), newline flattening, and PowerShell single-quote escaping. FocusSession returns (false, nil) for v1 — wt.exe exposes no programmatic tab-enumeration API. - Split claude harness runPS per-OS: POSIX `ps -axo pid,command` on unix; PowerShell `Get-CimInstance Win32_Process | … Select-Object -ExpandProperty CommandLine` on Windows. - Release workflow matrix now builds flow-windows-amd64.exe on ubuntu-latest (CGO disabled; pure Go via modernc.org/sqlite). - CI matrix runs `go test ./...` on ubuntu/macos/windows-latest and `go build ./...` for all three targets. - README: second <details> block for Windows install (PowerShell Invoke-WebRequest, %LOCALAPPDATA%\Programs\flow, no xattr). "Where flow runs" updated. Shared DB-seed helpers (seedTask, seedTaskAtCwd) moved from do_test.go to testhelpers_test.go so non-spawn tests can use them cross-platform. App tests that drive the spawn path through iterm stubs are tagged darwin. Known v1 Windows limitations: no tab-focus on live sessions; --with inject text containing single quotes may break PowerShell parsing (the shell-safe bootstrap prompt works fine); make install/uninstall remains bash-only — Windows users use the PowerShell snippet in the README. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
`AUX` is a reserved DOS device name on Windows, so any file named `aux.<ext>` fails to check out — `git checkout` returns "error: invalid path 'internal/app/aux.go'" with rc=128. The Windows CI job added in the preceding commit hit this before it could even reach `go build`, and matrix fail-fast cascaded the cancellation to the ubuntu and macos test jobs. Rename internal/app/aux.go → auxfiles.go (and aux_test.go → auxfiles_test.go) via `git mv` so history is preserved. The exported / package-internal function names (`enumerateAuxFiles`) are unchanged; only the on-disk file name needed to change. Also set fail-fast: false on the test and build matrices so future single-job failures yield full signal on every push instead of cancelling siblings. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
`os.UserHomeDir()` on Windows reads %USERPROFILE% (with %HOMEDRIVE%+%HOMEPATH% as fallback), not $HOME. Tests that overrode only HOME silently leaked writes into the real runner's profile — `C:\Users\runneradmin\.claude\` — and cascaded into "skill already exists" failures across the skill suite. Introduce a testHome(t, dir) helper in testhelpers_test.go that sets both HOME and USERPROFILE via t.Setenv (auto- cleanup). Route initTempFlowRoot and withTempHome through it. Also fix TestCmdEditPlaybook: EDITOR=/usr/bin/true doesn't exist on Windows. Add a noopEditor() helper that returns "true" on Unix and "cmd /c rem" on Windows — both are no-ops that exit 0 regardless of file-path argument. These were the only Windows-specific test issues — the 18 failures in PR #62 CI all funnel into one of these two root causes (HOME pollution + missing editor binary). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Native Windows support across binary, spawn layer, release pipeline, and install docs.
iterm,terminal,warp,ghostty) and the app tests that depend on iterm stubs. Cross-platform DB-seed helpers moved totesthelpers_test.goso non-spawn tests still compile everywhere.spawner_darwin.go/spawner_windows.go/spawner_unix.gosharing theBackendenum + POSIXShellQuote. Windows defaults toBackendWT; linux defaults to zellij/kitty.internal/wtpackage — Windows Terminal backend viawt.exe -w 0 nt -d <cwd> --title <title> powershell.exe -NoExit -Command <ps>. Env injected as$env:NAME='value';.FocusSessionreturns(false, nil)for v1 —wt.exeexposes no tab-enumeration API.runPSsplit —claude_ps_unix.gokeepsps -axo; newclaude_ps_windows.gousespowershell.exe -NoProfile -NonInteractive -Command "Get-CimInstance Win32_Process | ... | Select -ExpandProperty CommandLine".flow-windows-amd64.exeonubuntu-latest(CGO disabled; pure Go viamodernc.org/sqlite); included inSHA256SUMS.testjob runs on ubuntu/macos/windows-latest;buildjob cross-compiles all three.<details>block for Windows install (PowerShellInvoke-WebRequest,%LOCALAPPDATA%\Programs\flow, noxattr; prereqs: Windows Terminal + Claude Code on PATH). "Where flow runs" section updated.Known v1 limitations on Windows:
flow do --withinject text containing single quotes may break PowerShell parsing — POSIX'\''escape doesn't translate to PowerShell''. Shell-safe bootstrap prompt path is unaffected.make install/make uninstallremain bash-only; Windows users use the PowerShell install snippet in the README.Closes the "Add Windows support to the flow CLI" task tracked locally in flow.
Test plan
go build ./...succeeds on darwin, linux, windows (cross-compiled locally)go vet ./...clean on all three OSesgo test ./...passes on darwin (12 packages green)GOOS=windows/GOOS=linuxwindows-latestgo test ./...passes (this PR triggers it for the first time)ubuntu-latestgo test ./...passesmacos-latestgo test ./...passesflow init,flow add task,flow do <slug>opens a Windows Terminal tab running Claude Codeflow-windows-amd64.exe+ checksums🤖 Generated with Claude Code