Skip to content

new skills#24

Open
alvinsng wants to merge 2 commits intomasterfrom
alvin-new-skills
Open

new skills#24
alvinsng wants to merge 2 commits intomasterfrom
alvin-new-skills

Conversation

@alvinsng
Copy link
Copy Markdown

No description provided.

Comment thread plugins/code-review/skills/create-pr/SKILL.md

```bash
# Example with npm + turbo
npm run fix -- --filter=<workspace1> --filter=<workspace2>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment here about language agnostic

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 3ef29f1. follow-up-on-pr now points at the create-pr CI-checks template (which is language-agnostic) and shows filter/target patterns across JS/TS monorepos, Python, Rust, Go, JVM, and Bazel.

- You need both to answer: "what did the model receive?" and "what did it actually do?"

3. **Use Bun's proxy env var explicitly**
- `BUN_CONFIG_PROXY` is the important one.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

language/framework agnostic?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 3ef29f1. Rewrote http-toolkit-intercept as runtime-agnostic: the skill now works for any runtime that respects a proxy (Node.js, Bun, Deno, Python, Go, Ruby, JVM, .NET, PHP, Rust, curl/shell, Docker). Added a Runtime proxy matrix covering the proxy env vars / JVM flags and TLS-bypass options per runtime, and generalized the quick-start away from Bun specifics (Bun is still called out as a special case since it requires BUN_CONFIG_PROXY, but it's no longer the lead example). Also updated the plugin README and top-level README descriptions.

…framework agnostic

Addresses PR #24 review feedback from @factory-davidgu. Generalize the
three skills away from JS/TS (npm/turbo) and Bun/Node specifics:
- create-pr: describe verification categories and show examples across
  ecosystems (JS/TS, Python, Rust, Go, JVM, Ruby) instead of hard-coded
  npm/turbo commands.
- follow-up-on-pr: same generalization for the CI-check step.
- http-toolkit-intercept: replace Bun-centric guidance with a runtime
  proxy matrix covering Node, Bun, Deno, Python, Go, Ruby, JVM, .NET,
  PHP, Rust, curl/shell, and Docker.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants