fix(droid-control): outro wordmark ascii + fanning blade alignment#25
Merged
factory-ain3sh merged 1 commit intomasterfrom Apr 21, 2026
Merged
fix(droid-control): outro wordmark ascii + fanning blade alignment#25factory-ain3sh merged 1 commit intomasterfrom
factory-ain3sh merged 1 commit intomasterfrom
Conversation
Polish the droid-control outro card: - Correct the DROID ASCII glyphs in the wordmark layer. - Dedupe the wordmark between the two outro components so it only lives in one place (shared DroidWordmark). - Center the fanning rotor wedges on the rotor's actual visual center (303.105, 319.528 in 613x650 space) instead of the SVG box center, so each 45-degree slice respects the rotor's 8-fold symmetry and the blade seams disappear. - Rename the components so the parent/child relationship is obvious: FanningRotorOutro -> DroidOutro (the full fan -> crossfade -> wordmark sequence) and BigDroidLogoOutro -> DroidWordmark (just the wordmark piece). - Update ARCHITECTURE.md row to match the new name and describe the outro sequence. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
shashank-factory
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Polish the Droid outro card. Fixes the ASCII
DROIDwordmark glyphs (they were subtly wrong: mis-shapedR, inconsistentDsizing), centers the fanning rotor wedges on the rotor's actual visual center so the blade seams line up with the logo's 8-fold symmetry, and dedupes the wordmark so it only lives in one place. Also renames the two outro-related components so the parent/child relationship is obvious — the full outro sequence (fan → crossfade → wordmark) isDroidOutro, and the shared wordmark piece isDroidWordmark.Related Issue
N/A — small follow-up polish on the droid-control outro composition. No ticket.
Potential Risk & Impact
Low risk, scoped entirely to the droid-control Remotion outro card:
git mv), and no other consumer referenced the old names (rgconfirmed clean).ShowcaseCompositionAPI, schema, props, and default props are untouched — existing render invocations continue to work.ARCHITECTURE.mdrow updated to match the new component name and describe the outro sequence.How Has This Been Tested?
cd plugins/droid-control/remotion && npx tsc --noEmit— passes clean.OutroPreviewcomposition against the target reference. Fanning frame, crossfade, and post-crossfadeDROIDwordmark match the expected output. Temp composition and reference renders were not committed.rg -n "FanningRotorOutro|BigDroidLogoOutro"in the repo returns no remaining references after rename.Root Cause Analysis
How the bugs were traced.
DROIDreference revealed subtly wrong glyphs — theRwas shaped like an invertedP, and theDs were not the same width as the other block letters. Both the oldBigDroidLogoOutroandFanningRotorOutroshipped their own copy of the ASCII art, so the error was duplicated.50% 50%) and clipping with a triangle anchored there, but the rotor's visual center of mass sits slightly off-box (~303.105, 319.528in 613×650 space). Each 45° slice therefore didn't land on the rotor's real 8-fold symmetry axis, producing the seam.How root cause drove the fix.
DROID_ASCIIconstant insideDroidWordmarkand corrected the glyphs in one place. The previously-duplicated copy in the outro was removed; the outro now renders<DroidWordmark palette={palette} />.50% 50%/-306.5 -325offsets with the rotor's measured visual center. Thetransform-origin, margin compensation, and clip-path polygon all now reference the same computed point, so every slice respects the rotor's 8-fold symmetry and the seams disappear — without jump-cutting to a full-logo overlay (an earlier attempt that felt jarring).