Skip to content

Conversation

@Cwagne17
Copy link
Contributor

@Cwagne17 Cwagne17 commented Jul 5, 2023

This PR integrates the CLI subcommand validate with the parse configuration functions.

Currently this is a draft to show what the implementation could look like. Just wanted to show what it looks like so far.

Some of the hold-ups:

  1. Error handling, hcl.Diagnostics isn't appropriate for all the error types. We will want to switch over to use our own custom type.
  2. Unsure what the plan for multiple configurations is
  3. Unsure if we want to use a flag for validate or if just args[0] is ok.
  4. Logs aren't the prettiest atm
  5. Error handling at the end of the validate command should be abstracted

@Cwagne17 Cwagne17 self-assigned this Jul 5, 2023
@Cwagne17 Cwagne17 merged commit 4a49586 into main Aug 1, 2023
@Cwagne17 Cwagne17 deleted the christopherwagner4474/sc-33/implement-validate-subcommand-in-factory branch August 1, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants