Add circleci config and pre commit configuration #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosueMolinaMorales
approved these changes
Aug 4, 2023
Base automatically changed from
christopherwagner4474/sc-33/implement-validate-subcommand-in-factory
to
main
August 22, 2023 19:38
Cwagne17
deleted the
christopherwagner4474/sc-29/setup-factory-cicd-workflow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR adds circleci configuration to build the project in CI and also defines TODO items that wouldn't be appropriate to implement now but should be integrated once work items are developed.
Additionally, the PR sets up pre commit configuration for local development to format, lint, and resolve imports.
TODOs
Release Notes (draft)
Added pre-commit-config and circleci configuration to enforce code quality and the ability to compile