Skip to content

Conversation

@javorosas
Copy link
Member

No description provided.

This comment was marked as outdated.

@javorosas javorosas requested a review from Copilot July 11, 2025 14:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new endpoint and related schemas for updating an organization’s self-invoice settings to the OpenAPI documentation, and bumps dependencies for the docs site.

  • Bumped Docusaurus, React, and related tool versions in package.json and enabled the v4 flag in docusaurus.config.js.
  • Introduced /organizations/{organization_id}/self-invoice PUT in both Spanish and English specs, with code samples and comprehensive response definitions.
  • Extended the Organization model with new fields (logo_url, timezone, receipts and self_invoice settings) and defined the corresponding request body schema.

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
website/package.json Updated Docusaurus core, React, and other dependencies to newer minor versions
website/docusaurus.config.js Enabled the future.v4 feature flag for the Docusaurus config
website/openapi_v2.yaml Added the self-invoice endpoint, new request/response schemas, fixed security scheme name, and extended Organization schema
website/openapi_v2.en.yaml Mirrored the above additions and corrections in the English version of the OpenAPI spec
Comments suppressed due to low confidence (3)

website/openapi_v2.yaml:10513

  • Renaming the property "has_certificates" to "has_certificate" is a breaking change for existing API clients; consider introducing the new field alongside the old one or clearly documenting this change with a version bump.
            has_certificate:

website/openapi_v2.yaml:10786

  • The request body schema for self-invoice settings does not declare which fields are required, making the API contract unclear. Consider adding a required array listing mandatory properties (e.g., allowed_cfdi_uses, apply_resico_isr, support_email).
    OrganizationSelfInvoiceInput:

website/openapi_v2.yaml:4588

  • [nitpick] Consider expanding the abbreviation config. to configuración for clarity and consistency with other endpoint summaries (e.g., Editar configuración de autofactura).
      summary: Editar config. autofactura

@javorosas javorosas merged commit 6016a6c into main Jul 16, 2025
@javorosas javorosas deleted the feat/edit-organization-self-invoice-settings branch July 16, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants