Tarea 2589 Añadir albarán facturado al total#39
Merged
daniel89fg merged 2 commits intoFacturaScripts:masterfrom Mar 17, 2026
Hidden character warning
The head ref may contain hidden characters: "A\u00f1adir-albaran-facturado-total"
Merged
Tarea 2589 Añadir albarán facturado al total#39daniel89fg merged 2 commits intoFacturaScripts:masterfrom
daniel89fg merged 2 commits intoFacturaScripts:masterfrom
Conversation
Contributor
|
este pr lo estoy cambiando bastante, hay muchos casos que no están contemplados. |
Contributor
Author
|
Debería de haber incluido más test por ejemplo? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Se ha agregado a la función purchaseDeliveryNotes() y a la función salesDeliveryNotes() que son los que devuelven los albaranes del cliente, aparte de que se agreguen los albaranes editables, la comprobación de que si un albarán no editable(facturado) no tiene la factura asociada a este proyecto se sume el total. Mismo código para ambos métodos ya que hacen lo mismo.
Se ha creado el Unit Test ProjectTotalManagerTest.php el cual ha pasado (OK (21 tests, 105 assertions).