-
Notifications
You must be signed in to change notification settings - Fork 12
Support fmt format and other changes #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Cute! Thanks. |
dennisklein
reviewed
Aug 22, 2019
dennisklein
approved these changes
Aug 22, 2019
Co-Authored-By: Dennis Klein <dennis.klein.github@gmail.com>
cf60c04 to
ec2540f
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LOGF(severity, ...)The arguments are given tofmt::formatand the result is logged, e.g.LOGF(info, "Hello {}!", "world");LOGP(severity, ...)The arguments are given tofmt::printfand the result is logged, e.g.LOGP(info, "Hello %s!", "world");LOGN(severity)that outputs an empty line (ping @fuhlig1).LOGV(severity, verbosity)that allows to override current verbosity just for the current call.The fmt library is bundled with the code (version 5.3.0), but users can override this by providing an external fmt installation via
-DUSE_EXTERNAL_FMT=ON -DFMT_ROOT=/fmt/location. If fmt is external, projects that use FairLogger need to find fmt.@ktf Solves #16.