Little Cleanup FairRootManager#1343
Merged
karabowi merged 1 commit intoFairRootGroup:devfrom Feb 10, 2023
Merged
Conversation
ChristianTackeGSI
force-pushed
the
pr/frm
branch
from
a509725 to
0c2b3de
Compare
* Turn fObj2 into std::vector * Drop fCurrentEntryNo, fTimeforEntryNo
ChristianTackeGSI
force-pushed
the
pr/frm
branch
from
0c2b3de to
ec2f3a6
Compare
Comment on lines
+774
to
+780
| if (!newentry) { | ||
| /** if we do not find an object corresponding to the branch in the folder structure | ||
| * then we have no idea about what type of object is this and we cannot set the branch address | ||
| */ | ||
| LOG(info) << " Branch: " << BrName << " not found in Tree."; | ||
| // Fatal(" No Branch in the tree", BrName ); | ||
| return 0; | ||
| return nullptr; |
Member
Author
There was a problem hiding this comment.
It looks like FairRootManager::UpdateBranches expects all pointers in fObj2 to be valid. While this looks like it handles a nullptr in fObj2.
3 tasks
karabowi
approved these changes
Feb 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a little step towards making the
GetObjectcode more readable.Checklist: