Clean FairRootManager::GetObject function#1353
Merged
ChristianTackeGSI merged 1 commit intoFairRootGroup:devfrom Feb 15, 2023
Merged
Clean FairRootManager::GetObject function#1353ChristianTackeGSI merged 1 commit intoFairRootGroup:devfrom
FairRootManager::GetObject function#1353ChristianTackeGSI merged 1 commit intoFairRootGroup:devfrom
Conversation
ChristianTackeGSI
previously approved these changes
Feb 15, 2023
Member
ChristianTackeGSI
left a comment
ChristianTackeGSI
left a comment
There was a problem hiding this comment.
Could you add a \return non-owning pointer to found object, or nullptr to the doxygen-comment of GetObject as well?
Removed unused `fRootFolder`. Removed code present anyways in `ActivateBranch`.
karabowi
force-pushed
the
clean_GetObject
branch
from
88ef75c to
9afb288
Compare
Collaborator
Author
|
Good idea, done! |
ChristianTackeGSI
approved these changes
Feb 15, 2023
Member
|
Thanks for that good cleanup. Now it's a little easier to understand, what's happening there. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unused
fRootFolder.Removed code present anyways in
ActivateBranch.Checklist: