Remove unused FairRunOnline::InitContainers() function#1396
Merged
ChristianTackeGSI merged 2 commits intoFairRootGroup:devfrom May 15, 2023
Merged
Conversation
Member
ChristianTackeGSI
left a comment
ChristianTackeGSI
left a comment
There was a problem hiding this comment.
Very good catch!
I have a few notes.
The function is not being invoked, and was not used. Tested with R3BRoot. Adjusted the LOG() messages. Added corresponding CHANGELOG notice. Addresses issue FairRootGroup#1346.
karabowi
force-pushed
the
pr/FairRunOnline_NoInitContainers
branch
2 times, most recently
from
41b5b23 to
47081ea
Compare
Member
ChristianTackeGSI
left a comment
ChristianTackeGSI
left a comment
There was a problem hiding this comment.
I also wonder, whether we should refactor this a bit into some common FairRun feature?
Or should FairRunAna and FairRunOnline have common helper base class?
Just pondering! I haven't thought this through, really!
karabowi
force-pushed
the
pr/FairRunOnline_NoInitContainers
branch
from
47081ea to
98c2cf6
Compare
karabowi
force-pushed
the
pr/FairRunOnline_NoInitContainers
branch
from
98c2cf6 to
d5626f0
Compare
Added check for `fStatic` in the `FairRunOnline::EventLoop()`. When `fStatic` is set to true by `SetContainerStatic()`, `ReInit()` will not be called when changed `RunId` detected.
karabowi
force-pushed
the
pr/FairRunOnline_NoInitContainers
branch
from
d5626f0 to
d4a8417
Compare
ChristianTackeGSI
approved these changes
May 15, 2023
This was referenced May 19, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function is not being invoked, and was not used.
Addresses issue #1346.
Checklist: