fix: upstream alignment for gradle PR readiness#22
Merged
Conversation
Upstream uses LimitsConfig in 7 locations. Our fork destructively replaced it with GradleConfig. Restore it so upstream PRs are clean cherry-picks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Kevin Brightwell <kevin.brightwell@faire.com>
The is_integration bool was threaded through filter_test(), filter_test_with_packages(), filter_gradle_output(), and run() but never used (always prefixed with _). Remove the parameter, delete the dead is_integration_test() function, and make is_integration_task_name() private. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Kevin Brightwell <kevin.brightwell@faire.com>
Only referenced by its own tests after the _is_integration parameter removal. Delete function and tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Kevin Brightwell <kevin.brightwell@faire.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LimitsConfigstruct +pub fn limits()inconfig.rsalongsideGradleConfig— upstream uses it in 7 locations that our fork broke_is_integrationparameter fromfilter_test(),filter_test_with_packages(),filter_gradle_output(), andrun()is_integration_test()andis_integration_task_name()functions + their testsTracking issue: #21 (Phase 1)
Test Plan
cargo fmt --all --checkcleancargo clippy --all-targetsclean (no new warnings in gradle/)[limits]section still parses (serde defaults)🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com