Skip to content

Conversation

@HardlyDifficult
Copy link
Collaborator

What?

Please describe what you're trying to accomplish in this PR.

Why?

What problem does this solve? Why is this important? What's the context?

Screenshots (optional)

@thibauld thibauld merged commit 703866a into dev Jun 12, 2025
1 of 2 checks passed
@thibauld thibauld deleted the cantonDev branch June 12, 2025 23:24
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Environment Variables Not Expanding in Docker

In both deploy.prod.yaml and deploy.dev.yaml workflows, the FAIRMINT_* and TRANSFER_AGENT_* environment variables are passed to Docker using -e VAR='${VAR}'. The single quotes prevent shell expansion, causing the container to receive the literal string "${VAR}" instead of the actual secret value. This results in incorrect or missing credentials, breaking application functionality that relies on these variables.

.github/workflows/deploy.dev.yaml#L129-L135

-e ETHERSCAN_L2_API_KEY='${ETHERSCAN_L2_API_KEY}' \
-e FAIRMINT_MAINNET_USER_ID='${FAIRMINT_MAINNET_USER_ID}' \
-e FAIRMINT_MAINNET_PARTY_ID='${FAIRMINT_MAINNET_PARTY_ID}' \
-e TRANSFER_AGENT_MAINNET_CLIENT_SECRET='${TRANSFER_AGENT_MAINNET_CLIENT_SECRET}' \
-e FAIRMINT_DEVNET_USER_ID='${FAIRMINT_DEVNET_USER_ID}' \
-e FAIRMINT_DEVNET_PARTY_ID='${FAIRMINT_DEVNET_PARTY_ID}' \
-e TRANSFER_AGENT_DEVNET_CLIENT_SECRET='${TRANSFER_AGENT_DEVNET_CLIENT_SECRET}' \

.github/workflows/deploy.prod.yaml#L128-L134

-e ETHERSCAN_L2_API_KEY='${ETHERSCAN_L2_API_KEY}' \
-e FAIRMINT_MAINNET_USER_ID='${FAIRMINT_MAINNET_USER_ID}' \
-e FAIRMINT_MAINNET_PARTY_ID='${FAIRMINT_MAINNET_PARTY_ID}' \
-e TRANSFER_AGENT_MAINNET_CLIENT_SECRET='${TRANSFER_AGENT_MAINNET_CLIENT_SECRET}' \
-e FAIRMINT_DEVNET_USER_ID='${FAIRMINT_DEVNET_USER_ID}' \
-e FAIRMINT_DEVNET_PARTY_ID='${FAIRMINT_DEVNET_PARTY_ID}' \
-e TRANSFER_AGENT_DEVNET_CLIENT_SECRET='${TRANSFER_AGENT_DEVNET_CLIENT_SECRET}' \

Fix in Cursor


Was this report helpful? Give feedback by reacting with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants