Skip to content

Update quickstart.md#228

Merged
rbren merged 1 commit intoFairwindsOps:masterfrom
ejether:patch-1
Jun 27, 2023
Merged

Update quickstart.md#228
rbren merged 1 commit intoFairwindsOps:masterfrom
ejether:patch-1

Conversation

@ejether
Copy link
Copy Markdown

@ejether ejether commented Jun 15, 2023

go get is no longer supported outside of a module.

✗ go version
go version go1.20.3 darwin/arm64
▶  go get github.com/fairwindsops/nova
go: go.mod file not found in current directory or any parent directory.
	'go get' is no longer supported outside a module.
	To build and install a command, use 'go install' with a version,
	like 'go install example.com/cmd@latest'
	For more information, see https://golang.org/doc/go-get-install-deprecation
	or run 'go help get' or 'go help install'.

✗ go install github.com/fairwindsops/nova
go: 'go install' requires a version when current directory is not in a module
	Try 'go install github.com/fairwindsops/nova@latest' to install the latest version

This PR fixes #

Out dated documentation for new go standards

Checklist

  • I have signed the CLA
  • I have updated/added any relevant documentation

Description

What's the goal of this PR?

What changes did you make?

What alternative solution should we consider, if any?

`go get` is no longer supported outside of a module. 
```
▶  go get github.com/fairwindsops/nova
go: go.mod file not found in current directory or any parent directory.
	'go get' is no longer supported outside a module.
	To build and install a command, use 'go install' with a version,
	like 'go install example.com/cmd@latest'
	For more information, see https://golang.org/doc/go-get-install-deprecation
	or run 'go help get' or 'go help install'.

✗ go install github.com/fairwindsops/nova
go: 'go install' requires a version when current directory is not in a module
	Try 'go install github.com/fairwindsops/nova@latest' to install the latest version
```
@ejether ejether requested review from bbensky and rbren as code owners June 15, 2023 21:20
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 15, 2023

CLA assistant check
All committers have signed the CLA.

@sudermanjr sudermanjr added bug Something isn't working triage This bug needs triage and removed bug Something isn't working triage This bug needs triage labels Jun 15, 2023
@ejether
Copy link
Copy Markdown
Author

ejether commented Jun 15, 2023

I noticed a couple other references to go get that I didn't catch in this.

@rbren
Copy link
Copy Markdown
Contributor

rbren commented Jun 27, 2023

Thanks EJ!

@rbren rbren merged commit a405bf7 into FairwindsOps:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants