remove deprecated ioutil references#248
Merged
sudermanjr merged 1 commit intoFairwindsOps:masterfrom Aug 28, 2023
Merged
Conversation
sudermanjr
approved these changes
Aug 25, 2023
Member
sudermanjr
left a comment
sudermanjr
left a comment
There was a problem hiding this comment.
Thanks for the PR! LGTM, but we'll need a codeowner review.
nungster
reviewed
Aug 25, 2023
sudermanjr
changed the title
sudermanjr
changed the title
bbensky
approved these changes
Aug 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the use of the now depracted
ioutilpackage, replacing functions it provided with the accordingosoriofunctions.Checklist
Description
What's the goal of this PR?
To remove any references to
ioutilwhile ensuring the functionality that it provided is still in place with the newer alternatives.What changes did you make?
Changed all references as follows:
ioutil.TempFile->os.CreateTempioutil.ReadFile->os.ReadFileioutil.ReadAll->io.ReadAllioutil.WriteFile->os.WriteFileAlso changed a capitalized
fmt.Errorfmessage as per Go convention.What alternative solution should we consider, if any?