[pull] trunk from SeleniumHQ:trunk#212
Merged
pull[bot] merged 6 commits intoFairyWorld:trunkfrom Jan 9, 2024
Merged
Conversation
[java] Update subPath for ProxyNodeWebsockets Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
…WaitingForDebugger is invoked (#13330) * Use .GetType() instead of typeof() for determining the response type of a command. typeof() determines the type compile time. * Duplicated TryGetCommandResponseType function * Added function to DevToolsSession.cs to enable waiting for new targets until runtime.runIfWaitingForDebugger is invoked. * Fix copy paste issue * Moved WaitForDebuggerOnStart function to DevToolsOptions class. * Refactored DevToolsOptions usage to remove redundant functions from interface. Marked old functions with only protocol version as obsolete. * Refactor to remove duplicate code for auto detecting ProtocolVersion. * Fixed comments. --------- Co-authored-by: Nikolay Borisenko <22616990+nvborisenko@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )