Add units to chart data point hover card#1049
Merged
Merged
Conversation
Member
1Blademaster
commented
Mar 4, 2026
1Blademaster
commented
Contributor
There was a problem hiding this comment.
Pull request overview
Adds dataset units to the Chart.js tooltip (hover card) in the Falcon Log Analyser charts by customizing the tooltip label callback and reusing the unit stored in dataset.yAxisID.
Changes:
- Introduced a shared
getChartLabeltooltip callback to append units to tooltip labels. - Wired the custom tooltip label callback into both
dataflashOptionsandfgcsOptions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.