Fix bug with config not being highlighted on navbar#1096
Merged
1Blademaster merged 2 commits intoMar 17, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates how the GCS tracks and emits “state” changes, especially around the /config route, so the UI can still update its current page without always emitting a set_state socket event.
Changes:
- Middleware: always updates Redux
currentPageonemitSetState, but suppresses theset_statesocket emit when the state is exactly"config". - Layout: always dispatches
emitSetState(currentPageLowerCase)(removes the prior"config"special-casing). - Navbar: adds a
console.log(currentPage)debug statement.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| gcs/src/redux/middleware/emitters.js | Prevents socket set_state emission for the "config" state while still updating Redux currentPage. |
| gcs/src/components/layout.jsx | Always dispatches emitSetState on page changes (including "config"). |
| gcs/src/components/navbar.jsx | Adds a debug log of currentPage. |
Comments suppressed due to low confidence (1)
gcs/src/components/layout.jsx:44
- The
useEffectusesaircraftTypeStringandshouldFetchAllMissionsOnDashboard, but they are not included in the dependency array. This can lead to stale behavior (e.g., missing a loiter radius fetch whenaircraftTypeStringchanges while on the dashboard, or not fetching missions aftershouldFetchAllMissionsOnDashboardflips). Add the missing dependencies (anddispatchif you follow exhaustive-deps) or split this effect so each piece has the correct deps.
dispatch(emitSetState(currentPageLowerCase))
if (!connectedToDrone) return
if (currentPageLowerCase == "dashboard") {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.