Add mission frame choice selection#1099
Merged
1Blademaster merged 2 commits intoMar 18, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a user-selectable MAVLink mission frame choice in the GCS mission-related tables (mission/fence/rally), replacing the previously read-only frame display with a dropdown.
Changes:
- Introduces
getFrameDropdownData()to provide dropdown options for mission frame selection. - Adds
getPositionFrameValue()helper to reverse-mapMAV_FRAME_LISTnames to numeric frame IDs. - Updates mission, fence, and rally table rows to render a
<Select>for theframefield and dispatch updates on change.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| gcs/src/helpers/mavlinkConstants.js | Adds frame dropdown data helper; introduces new import that creates a circular dependency. |
| gcs/src/helpers/dataFormatters.js | Adds reverse lookup helper for MAV frame IDs (currently returns string/undefined). |
| gcs/src/components/missions/rallyItemsTableRow.jsx | Replaces frame display with selectable dropdown. |
| gcs/src/components/missions/missionItemsTableRow.jsx | Replaces frame display with selectable dropdown. |
| gcs/src/components/missions/fenceItemsTableRow.jsx | Replaces frame display with selectable dropdown. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1Blademaster
deleted the
1007-feature-add-ability-to-update-waypoint-frame
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.