Skip to content

Alpha 0.1.10/573 add moveable home location#597

Merged
1Blademaster merged 3 commits intorelease-alpha-0.1.10from
alpha-0.1.10/573-add-moveable-home-location
Aug 3, 2025
Merged

Alpha 0.1.10/573 add moveable home location#597
1Blademaster merged 3 commits intorelease-alpha-0.1.10from
alpha-0.1.10/573-add-moveable-home-location

Conversation

@1Blademaster
Copy link
Copy Markdown
Member

No description provided.

@1Blademaster 1Blademaster requested a review from Copilot August 2, 2025 20:41
@1Blademaster 1Blademaster linked an issue Aug 2, 2025 that may be closed by this pull request
@1Blademaster 1Blademaster changed the base branch from main to release-alpha-0.1.10 August 2, 2025 20:41

This comment was marked as outdated.

@1Blademaster 1Blademaster requested a review from Copilot August 2, 2025 20:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds the ability to move the home location in the missions view by making it draggable and providing a context menu option. The key change is enabling users to interactively set the home position on the map.

Key changes:

  • Made the home marker draggable and added context menu option to set home position
  • Added function to update mission home position with coordinate conversion
  • Updated coordinate conversion to use integer parsing

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
gcs/src/missions.jsx Added updateMissionHomePosition function and UI tooltip for home location
gcs/src/helpers/dataFormatters.js Changed coordToInt to use parseInt for integer conversion
gcs/src/components/missions/missionsMap.jsx Added context menu item and drag callback for setting home position
gcs/src/components/mapComponents/homeMarker.jsx Made home marker draggable with drag end callback
Comments suppressed due to low confidence (1)

gcs/src/components/missions/missionsMap.jsx:293

  • The underscore parameter _ is unnecessarily destructured. Consider using just ({ x, y }) if the first parameter is not needed.
            updateMissionHomePositionDragCb={({ _, x, y }) => {

Comment thread gcs/src/helpers/dataFormatters.js
@1Blademaster 1Blademaster removed the request for review from NexInfinite August 3, 2025 16:53
@1Blademaster 1Blademaster merged commit 89c23bd into release-alpha-0.1.10 Aug 3, 2025
7 checks passed
@1Blademaster 1Blademaster deleted the alpha-0.1.10/573-add-moveable-home-location branch August 3, 2025 16:54
1Blademaster added a commit that referenced this pull request Sep 28, 2025
* Add moveable mission home location

* Remove unused deconstructed var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add moveable home location

3 participants