Alpha 0.1.10/573 add moveable home location#597
Merged
1Blademaster merged 3 commits intorelease-alpha-0.1.10from Aug 3, 2025
Merged
Alpha 0.1.10/573 add moveable home location#5971Blademaster merged 3 commits intorelease-alpha-0.1.10from
1Blademaster merged 3 commits intorelease-alpha-0.1.10from
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds the ability to move the home location in the missions view by making it draggable and providing a context menu option. The key change is enabling users to interactively set the home position on the map.
Key changes:
- Made the home marker draggable and added context menu option to set home position
- Added function to update mission home position with coordinate conversion
- Updated coordinate conversion to use integer parsing
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gcs/src/missions.jsx | Added updateMissionHomePosition function and UI tooltip for home location |
| gcs/src/helpers/dataFormatters.js | Changed coordToInt to use parseInt for integer conversion |
| gcs/src/components/missions/missionsMap.jsx | Added context menu item and drag callback for setting home position |
| gcs/src/components/mapComponents/homeMarker.jsx | Made home marker draggable with drag end callback |
Comments suppressed due to low confidence (1)
gcs/src/components/missions/missionsMap.jsx:293
- The underscore parameter
_is unnecessarily destructured. Consider using just({ x, y })if the first parameter is not needed.
updateMissionHomePositionDragCb={({ _, x, y }) => {
Kwash67
approved these changes
Aug 3, 2025
1Blademaster
added a commit
that referenced
this pull request
Sep 28, 2025
* Add moveable mission home location * Remove unused deconstructed var
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.