Alpha 0.1.10/621 show a warning if changes were made to the mission but not written to the drone yet#629
Merged
1Blademaster merged 9 commits intorelease-alpha-0.1.10from Aug 19, 2025
alpha-0.1.10/621-show-a-warning-if-changes-were-made-to-the-mission-but-not-written-to-the-drone-yet
Conversation
* Clean up mission tests * Fix bug with max slope gradient in missionStatistics * Add tests for getting specific missions * Add upload mission tests * Add unit tests for MissionController functionality * Address copilot review comments
* Fixed store, setup sockets, and started on dashboard * Dashboard basically done * Fixed map and refactored * Cleaned up code and fixed mission items * Fixes * fixed linting * AI Fixes * Moved gps out and fixed messages - more to move still * Updated messages * More moving of variables/cleaning up * Moved more things around :D * formatted D: * Fixed drone connection issues and states * formatted * FIXED IT WOOO * formatted * Kush fixes
* Fix activeTab state not updating bug * Move getFrameName function into dataFormatters file
…ing-if-changes-were-made-to-the-mission-but-not-written-to-the-drone-yet
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a warning system to notify users when they have made changes to mission data that haven't been written to the drone yet. The warning appears prominently in the UI and tracks changes across all three mission types (mission, fence, rally).
- Adds state tracking for unwritten changes across mission types
- Implements a visual warning component showing unwritten changes
- Updates change tracking logic when items are modified, added, or deleted
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| radio/app/endpoints/mission.py | Adds mission_type to the write result response |
| gcs/src/missions.jsx | Implements unwritten changes tracking state and warning UI component |
| gcs/src/components/missions/rallyItemsTableRow.jsx | Adds equality check to prevent unnecessary updates |
| gcs/src/components/missions/fenceItemsTableRow.jsx | Adds equality check to prevent unnecessary updates |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
NexInfinite
approved these changes
Aug 19, 2025
Contributor
NexInfinite
left a comment
NexInfinite
left a comment
There was a problem hiding this comment.
Code looks good, works for me
1Blademaster
deleted the
alpha-0.1.10/621-show-a-warning-if-changes-were-made-to-the-mission-but-not-written-to-the-drone-yet
branch
1Blademaster
added a commit
that referenced
this pull request
Sep 28, 2025
…ut not written to the drone yet (#629) * Attempt to add warning for unwritten changes * Add mission tests (#616) * Clean up mission tests * Fix bug with max slope gradient in missionStatistics * Add tests for getting specific missions * Add upload mission tests * Add unit tests for MissionController functionality * Address copilot review comments * Dashboard.jsx change for redux (#617) * Fixed store, setup sockets, and started on dashboard * Dashboard basically done * Fixed map and refactored * Cleaned up code and fixed mission items * Fixes * fixed linting * AI Fixes * Moved gps out and fixed messages - more to move still * Updated messages * More moving of variables/cleaning up * Moved more things around :D * formatted D: * Fixed drone connection issues and states * formatted * FIXED IT WOOO * formatted * Kush fixes * Fix activeTab state not updating bug (#625) * Fix activeTab state not updating bug * Move getFrameName function into dataFormatters file * Attempt to add warning for unwritten changes * Remove unused code * Remove mission_type from write_mission_result * Fix equality comparision statements --------- Co-authored-by: Julian Jones <37962677+NexInfinite@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.