Alpha 0.1.10/699 all popout windows broken in build#700
Merged
1Blademaster merged 4 commits intorelease-alpha-0.1.10from Sep 19, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes broken popout windows in the build by configuring proper multi-page entry points in Vite configuration and implementing proper window cleanup on application close.
- Adds rollup input configuration for multiple HTML entry points (linkStats, aboutWindow, webcam)
- Improves window lifecycle management with proper close event handling
- Updates file naming from .ts to .mts extension for Vite config
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| gcs/vite.config.mts | Adds rollup configuration with multiple entry points for popout windows and imports resolve function |
| gcs/tsconfig.node.json | Updates include path to match renamed vite.config.mts file |
| gcs/package.json | Bumps version from 0.1.9-alpha to 0.1.10-alpha-dev2 |
| gcs/electron/modules/webcam.ts | Fixes loadFile parameters and improves code formatting/structure |
| gcs/electron/main.ts | Adds close event handler to main window and restructures closeWithBackend function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
NexInfinite
reviewed
Sep 19, 2025
NexInfinite
approved these changes
Sep 19, 2025
1Blademaster
deleted the
alpha-0.1.10/699-all-popout-windows-broken-in-build
branch
1Blademaster
added a commit
that referenced
this pull request
Sep 28, 2025
* Start resolving build issues with multiple html files * Fix popout windows in build, fix popout windows not closing in build * Update gcs/electron/modules/webcam.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Change console warn message --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.