Fix guided mode bug and convert to redux#704
Merged
1Blademaster merged 5 commits intorelease-alpha-0.1.10from Sep 19, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a guided mode bug by converting guided mode pin data management from session storage to Redux state management. The change centralizes state management and ensures consistent data handling across components.
- Adds guided mode pin data to Redux store with proper state management
- Removes session storage usage in favor of Redux selectors and actions
- Integrates socket event handling for navigation reposition results into the Redux middleware
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| gcs/src/redux/slices/droneInfoSlice.js | Adds guided mode pin data state, reducer action, and selector |
| gcs/src/redux/middleware/socketMiddleware.js | Integrates nav reposition socket event handling and state updates |
| gcs/src/components/missions/missionsMap.jsx | Replaces session storage with Redux selector for guided mode data |
| gcs/src/components/dashboard/map.jsx | Removes local socket handling and session storage, uses Redux selector |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
NexInfinite
suggested changes
Sep 19, 2025
…cting-and-switching-back-to-guided' of https://github.com/Project-Falcon/GCS into alpha-0.1.10/703-guided-mode-marker-shows-after-reconnecting-and-switching-back-to-guided
NexInfinite
approved these changes
Sep 19, 2025
1Blademaster
deleted the
alpha-0.1.10/703-guided-mode-marker-shows-after-reconnecting-and-switching-back-to-guided
branch
1Blademaster
added a commit
that referenced
this pull request
Sep 28, 2025
* Fix guided mode bug and convert to redux * Update gcs/src/redux/slices/droneInfoSlice.js Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Moved map notification to use redux notification queue * Remove console log --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.