Fix duplicate mission fetching, show loading notification when fetchi…#712
Conversation
…ng mission on dashboard
There was a problem hiding this comment.
Pull Request Overview
This PR fixes duplicate mission fetching and adds loading notifications when fetching missions on the dashboard. The key changes optimize mission data retrieval and improve user experience by showing loading states.
Key changes:
- Simplifies error handling in mission controller by removing warning logs for failed mission item fetches
- Adds dashboard-specific mission fetching control to prevent unnecessary duplicate requests
- Implements loading notifications to provide user feedback during mission fetch operations
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| radio/app/controllers/missionController.py | Simplified error handling by removing warning logs for failed mission fetches |
| gcs/src/redux/slices/missionSlice.js | Added state management for dashboard mission fetching control and loading notifications |
| gcs/src/redux/middleware/socketMiddleware.js | Updated connection handling to manage dashboard mission fetch flag |
| gcs/src/redux/middleware/emitters.js | Added loading notification trigger when emitting mission fetch requests |
| gcs/src/helpers/notification.js | Added utility functions for loading notifications with update capability |
| gcs/src/components/layout.jsx | Implemented conditional mission fetching based on dashboard state flag |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
NexInfinite
left a comment
There was a problem hiding this comment.
Looks good, I think we'd want more "loading" notifications around. They seem like a good indicator - for example we could have a loading notification for when you connect to a drone and click off the modal as right now it just works in the background. Nothing related to this ticket tho.
…cator-on-dashboard-when-all-mission-is-being-read
#712) * Fix duplicate mission fetching, show loading notification when fetching mission on dashboard * Display errors on getCurrentMissionAll * Fix test * Fix merge
…ng mission on dashboard