Load params from a file#818
Merged
1Blademaster merged 8 commits intomainfrom Nov 5, 2025
Merged
Conversation
Closed
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to load parameters from a file, allowing users to review and apply parameter changes from external files. The feature includes a new modal to display parameter differences before applying them.
Key changes:
- Added file loading capability with parameter comparison and exclusion filtering
- Introduced new Redux state management for loaded parameters and modal visibility
- Created a modal component to display parameter differences before applying changes
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| gcs/src/redux/slices/paramsSlice.js | Added state properties and actions for managing loaded parameters and modal, includes debug console.log statements |
| gcs/src/params.jsx | Implemented loadParamsFromFile function with parameter comparison logic and cleanFloat helper |
| gcs/src/helpers/mavlinkConstants.js | Added EXCLUDE_PARAMS_LOAD array to filter out system parameters that shouldn't be loaded |
| gcs/src/components/params/rowItem.jsx | Fixed potential null reference with optional chaining operator |
| gcs/src/components/params/paramsToolbar.jsx | Added "Load params from file" button with upload icon |
| gcs/src/components/params/loadParamsFileModal.jsx | Created modal component to display and accept loaded parameter differences |
| gcs/electron/utils/paramsFile.ts | Added utility function to parse parameter files |
| gcs/electron/preload.js | Whitelisted new IPC channel for file loading |
| gcs/electron/main.ts | Implemented IPC handler for opening file dialog and reading parameter files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1Blademaster
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.