Added mavlink forwarding to mac menu bar#855
Merged
Kwash67 merged 2 commits intoNov 16, 2025
Merged
Conversation
Kwash67
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds MAVLink forwarding functionality to the macOS menu bar and reorganizes the menu structure by introducing a new "Advanced" menu section.
- Moved "Connection Stats" from the View menu to a new Advanced menu
- Added "MAVLink Forwarding" menu item to the Advanced menu
- Integrated IPC communication to trigger the MAVLink forwarding modal from the menu
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gcs/electron/main.ts | Reorganized menu structure: removed Connection Stats from View menu and created new Advanced menu containing both Connection Stats and MAVLink Forwarding options |
| gcs/electron/preload.js | Added "mavlink-forwarding:open" to the allowed IPC channels whitelist to enable secure communication between main and renderer processes |
| gcs/src/components/navbar.jsx | Added useEffect hook to listen for "mavlink-forwarding:open" IPC events and dispatch the modal open action |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1Blademaster
approved these changes
Nov 16, 2025
Kwash67
deleted the
797-add-mavlink-forwarding-modal-open-to-mac-menu-bar
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also reorganized the menu bar such that we have
Advanced: New menu containing:
We need to add shortcut keys for them in the future