Add popout FLA params window for dataflash bin logs#926
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a popout window feature to display flight log analyzer (FLA) parameters extracted from dataflash binary logs. When a dataflash .bin log file is loaded, users can now click a "View Params" button to open a dedicated window showing all parameters with search functionality.
Key changes:
- Added parameter extraction from PARM messages in dataflash binary logs
- Created a new popout window component with searchable parameter table
- Integrated params data flow through Redux state management
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| gcs/src/redux/slices/logAnalyserSlice.js | Added params state, actions, and selectors to Redux slice |
| gcs/src/flaParams.jsx | New React entry point for params window with Mantine provider |
| gcs/src/fla.jsx | Dispatches extracted params to Redux store |
| gcs/src/components/fla/graph.jsx | Adds "View Params" button and window opening logic |
| gcs/src/components/fla/flaParamsWindow.jsx | New component displaying searchable parameter table |
| gcs/flaParams.html | HTML entry point for params window |
| gcs/electron/utils/dataflashParserUtils.ts | Adds getParamObjects function to extract and sort parameters |
| gcs/electron/types/flaTypes.ts | Defines ParamObject interface and adds params to LogSummary |
| gcs/electron/preload.js | Registers IPC channels for params window communication |
| gcs/electron/modules/flaParamsWindow.ts | Electron window management module for params window |
| gcs/electron/main.ts | Registers params window IPC handlers and cleanup |
| gcs/electron/fla.ts | Extracts params from PARM messages during log processing |
Note: This PR is missing a critical build configuration update. The new flaParams.html entry point needs to be added to vite.config.mts in the rollupOptions.input object, otherwise the window won't be properly bundled for production builds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Waiting for response in discord, gonna move onto other tickets |
NexInfinite
left a comment
NexInfinite
left a comment
There was a problem hiding this comment.
On linux this opens a new window that doesn't load anything, if this can be proven to be working on windows then we can merge as the code looks good. We can look into the linux bugs later.
Think that was a bug, not sure when introduced icl. Works on windows: |
No description provided.