Add map display to FLA for dataflash bin logs#949
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds map display functionality to the Flight Log Analyzer (FLA) for dataflash bin logs. The feature allows users to visualize GPS/GPS2/POS position data from log files on an interactive satellite map alongside the existing graph visualization.
Changes:
- Added Redux state management for map position data with new actions and selectors
- Implemented a new map component that displays GPS, GPS2, and POS data with different colored tracks
- Integrated the map with the graph view using resizable panels
- Added parser utilities to extract and validate position data from dataflash log messages
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| gcs/src/redux/slices/logAnalyserSlice.js | Added mapPositionData state, reducer action, and selectors for managing position data |
| gcs/src/fla.jsx | Integrated mapPositionData dispatch and cleanup in the FLA component lifecycle |
| gcs/src/components/fla/graphConfigs.js | Updated chart configuration with maintainAspectRatio and dimension properties |
| gcs/src/components/fla/graph.jsx | Added resizable panel layout with Show/Hide Map button and map integration |
| gcs/src/components/fla/flaMap.jsx | New component implementing the map display with GPS/GPS2/POS tracks visualization |
| gcs/electron/utils/dataflashParserUtils.ts | Added functions to extract and validate GPS/POS position data from log messages |
| gcs/electron/types/flaTypes.ts | Added TypeScript interfaces for map position data structures |
| gcs/electron/fla.ts | Integrated map position data extraction in the log processing pipeline |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In another issue I want to add a waypoints/fences if available. I also want to try and display the drone's position in accordance to the mouse cursor on the map.