Fix loading custom presets for different log types#961
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in loading custom presets for different log types by introducing a centralized mapping function and adding support for MP telemetry logs. Previously, the code was constructing incorrect custom preset category keys (e.g., custom_dataflash_log instead of custom_dataflash) and using simple string comparisons that couldn't handle all log type values correctly.
Changes:
- Added
getPresetKeys()helper function to map log types to their corresponding category and storage keys - Added support for
mp_telemetrylog type with its own custom preset category - Refactored preset save/delete/find functions to use the new helper function for consistent key resolution
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| gcs/src/components/fla/presetsAccordion.jsx | Updated to use getPresetKeys() helper for resolving custom preset category keys instead of string concatenation |
| gcs/src/components/fla/presetCategories.js | Added getPresetKeys() helper function, MP telemetry support, and refactored localStorage loading to handle all preset types uniformly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.