Add log message description generation and update FLA to utilize new data#962
Merged
Conversation
1Blademaster
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds functionality to automatically generate log message descriptions from ArduPilot XML files and updates the FLA (Falcon Log Analyzer) component to display field-level tooltips with these descriptions. Previously, log message descriptions were hardcoded in JavaScript; now they are dynamically generated from upstream sources.
Changes:
- Adds a Python script to download and parse ArduPilot log message definition XML files, generating JSON files with message and field descriptions for both Copter and Plane variants
- Updates the FLA messages filter accordion to use the generated JSON data and display field descriptions as tooltips
- Adds runtime checks in Electron main process to verify required data files exist before app startup
- Integrates data generation into Windows and macOS build scripts
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| gcs/data/generate_log_message_descriptions.py | New Python script that downloads ArduPilot log message XML definitions, parses them, and generates JSON files with message and field descriptions |
| gcs/src/components/fla/messagesFiltersAccordion.jsx | Updated to import generated JSON files, added memoized FieldCheckbox component with tooltip support, and implemented field description lookup logic |
| gcs/src/helpers/logMessageDescriptions.js | Removed hardcoded dataflash log message descriptions (now sourced from generated JSON), retained MAVLink message descriptions |
| gcs/electron/main.ts | Added checkRequiredDataFiles function to verify generated JSON files exist at app startup, displays error dialog if missing |
| gcs/.gitignore | Added entries to ignore the two new generated JSON files (copter and plane log message descriptions) |
| building/windows/build.ps1 | Added call to generate_log_message_descriptions.py in the build process |
| building/macos/build.sh | Added call to generate_log_message_descriptions.py in the build process |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.