Skip to content

903 settings modal html touchup#986

Merged
ProgramPhantom merged 12 commits into
mainfrom
903-settings-modal-html-touchup
Feb 15, 2026
Merged

903 settings modal html touchup#986
ProgramPhantom merged 12 commits into
mainfrom
903-settings-modal-html-touchup

Conversation

@ProgramPhantom
Copy link
Copy Markdown
Contributor

Improvements:

  • Background colours now consistent with app defaults
  • Fixed 100% CPU
  • Fixed flickering and 100% CPU Text input (For maptiler API key)
  • Dramatically improved responsiveness
  • Added cog icon
  • Fixed strange jitter
  • Fixed reset button growing setting row height causing jump

…e this is adequate.

- Fixed tab panel height not being bounded by a scroll.
- Adjusted left padding on tabs
- Refixed bizarre jitter. Apparently this is a "sub-pixel rendering issue" and this z transform allows the browser to handle it.
@ProgramPhantom ProgramPhantom requested a review from a team February 14, 2026 14:01
@ProgramPhantom ProgramPhantom self-assigned this Feb 14, 2026
@ProgramPhantom ProgramPhantom linked an issue Feb 14, 2026 that may be closed by this pull request
@1Blademaster
Copy link
Copy Markdown
Member

image Can you decrease the gap between the tabs on the left and the main content?

@ProgramPhantom
Copy link
Copy Markdown
Contributor Author

image

@1Blademaster
Copy link
Copy Markdown
Member

I meant more this gap
image

@ProgramPhantom
Copy link
Copy Markdown
Contributor Author

Ohh sorry, should I leave what I just did?

@ProgramPhantom
Copy link
Copy Markdown
Contributor Author

image This good?

@1Blademaster
Copy link
Copy Markdown
Member

Yeah the tighter spacing on tabs is fine, I thought it got set automatically based on the largest tabs' width?

@1Blademaster
Copy link
Copy Markdown
Member

Yeah I think that looks a bit better

@ProgramPhantom
Copy link
Copy Markdown
Contributor Author

Yeah the tighter spacing on tabs is fine, I thought it got set automatically based on the largest tabs' width?

Not currently, I think that was causing the problem of overflowing when the window scaled. It's pretty easy to change, just a min-width value. Is this system fine?

@1Blademaster
Copy link
Copy Markdown
Member

Yeah the tighter spacing on tabs is fine, I thought it got set automatically based on the largest tabs' width?

Not currently, I think that was causing the problem of overflowing when the window scaled. It's pretty easy to change, just a min-width value. Is this system fine?

Yep seems fine. Don't forget about the merge conflict you have to fix

@ProgramPhantom
Copy link
Copy Markdown
Contributor Author

Is there a way to "open" the merge conflict in vc code? I can't solve the problem in the web editor bc I have wrapped one of the incoming changes in a new component.

@1Blademaster
Copy link
Copy Markdown
Member

1Blademaster commented Feb 15, 2026

Yes it's possible, there should be cli instructions for fixing the merge conflict if you check on the pr.
image

@ProgramPhantom
Copy link
Copy Markdown
Contributor Author

Hopefully done this right

Copy link
Copy Markdown
Member

@1Blademaster 1Blademaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me

@ProgramPhantom ProgramPhantom merged commit dad4fb2 into main Feb 15, 2026
5 checks passed
@ProgramPhantom ProgramPhantom deleted the 903-settings-modal-html-touchup branch February 15, 2026 10:55
@ProgramPhantom
Copy link
Copy Markdown
Contributor Author

Thanks Kush 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings modal HTML touchup

2 participants