-
Notifications
You must be signed in to change notification settings - Fork 30
Fix E2E tests #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix E2E tests #355
Conversation
Completed Working on "Code Review"✅ Workflow completed successfully. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Static Code Review 📊 ✅ All quality checks passed! |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI Code Review 🤖
Files Reviewed: 2
Comments Added: 0
Lines of Code Analyzed: 18
Critical Issues: 0
PR Health: Excellent 🔥
Give 👍 or 👎 on each review comment to help us improve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Importance counts: BLOCKER 0 · CRITICAL 0 · MAJOR 1 · MINOR 0 · SUGGESTION 0 · PRAISE 0.
Key themes
- E2E reliability: Chat duplicate-user regression test now allows generic errors, reducing confidence in UI messaging for conflicts.
Next steps
- Tighten the duplicate-user assertion so it still matches the quoted username (e.g., via regex) while keeping the case-insensitive check, ensuring the test fails on unrelated error strings.
PR Summary by Typo
Overview
This PR addresses flakiness in E2E tests for chat and user profile functionalities by adjusting timeouts and adding explicit waits to improve test stability.
Key Changes
waitForConfirmationMessagetimeouts inchat.spec.tsto prevent failures on slower environments.chat.spec.ts.page.waitForEvent('load')before logout inuserProfile.spec.tsto ensure proper navigation handling after the action.Work Breakdown
To turn off PR summary, please visit Notification settings.