document vector distance function#15
Merged
Merged
Conversation
galshubeli
added a commit
that referenced
this pull request
May 13, 2026
…ssions Two issues flagged by CodeRabbit + CodeQL on PR #478: 1. concurrency.group used github.ref, which in a pull_request event resolves to refs/pull/<N>/merge — a per-PR value. Two PRs merging to main simultaneously would have ended up in *different* concurrency groups and run in parallel, defeating the queue. Server-side CAS in /api/admin/update-graph (FalkorDB/GraphRAG-UI#152) would have caught the race, but parallel runs would still cost 2× LLM credit for what should be one ingestion. Use github.event.pull_request.base.ref so all merges to main share update-graph-main and queue properly. 2. The job ran with default GITHUB_TOKEN permissions. The work only needs to read repo source (for the git diff); nothing writes back to the repo. Added `permissions: { contents: read }`. Closes CodeQL alerts #14 + #15 ("workflow does not contain permissions"). No functional change beyond serializing concurrent merges and restricting the GITHUB_TOKEN scope. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.