Skip to content

gh-1000: Do not materialize text coordinates in Find All menu items.#1098

Merged
alabuzhev merged 1 commit into
FarGroup:masterfrom
MKadaner:mzk/gh-1000/dynamic-contents-of-fixed-menu-columns
May 10, 2026
Merged

gh-1000: Do not materialize text coordinates in Find All menu items.#1098
alabuzhev merged 1 commit into
FarGroup:masterfrom
MKadaner:mzk/gh-1000/dynamic-contents-of-fixed-menu-columns

Conversation

@MKadaner
Copy link
Copy Markdown
Contributor

Summary

Find All menu displays the line and position ("coordinates") of the found pattern in the fixed columns at the left side of the menu. The coordinates were formatted into the menu item text string, and to display them the corresponding part of the item text was printed in the fixed column.

After this change, Find All menu items' text is just the content of the corresponding editor line. To obtain the strings to display in the fixed columns, menu invokes the fixed_column_provider function which should be registered by the menu owner.

Macros should use Menu.GetItemExtendedData instead of extracting line and position of the found pattern from the item's text.

References

Checklist

@MKadaner MKadaner force-pushed the mzk/gh-1000/dynamic-contents-of-fixed-menu-columns branch from 301e5f7 to a893a13 Compare April 29, 2026 02:09
@sonarqubecloud
Copy link
Copy Markdown

… items.

Instead of extracting line and position of the found pattern from the item's text, macros should use Menu.GetItemExtendedData.
@MKadaner MKadaner force-pushed the mzk/gh-1000/dynamic-contents-of-fixed-menu-columns branch from a893a13 to 06953f4 Compare May 10, 2026 16:34
@MKadaner
Copy link
Copy Markdown
Contributor Author

@alabuzhev, when you have time, could you please review? It's not small but reasonably straightforward.

@alabuzhev alabuzhev merged commit 4627069 into FarGroup:master May 10, 2026
45 of 46 checks passed
@alabuzhev
Copy link
Copy Markdown
Contributor

Thanks

@MKadaner MKadaner deleted the mzk/gh-1000/dynamic-contents-of-fixed-menu-columns branch May 10, 2026 16:53
@MKadaner
Copy link
Copy Markdown
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants