gh-600: Shift+F7 and Alt+F7 now search in absolute directions#646
Conversation
908b4b2 to
3d8eadc
Compare
|
@rohitab, would you be so kind as to test this change? New Search / Replace dialog UX and changed behavior of |
9c5c1b4 to
c0a153f
Compare
|
@MKadaner sure thing. Should be able to do it by tomorrow. |
|
@MKadaner I just tested your changes. They look good. I did not find any issues with the search, but I do have a few suggestions for the Help files. I think the description for the Here is the current description for the Editor: Line 3169 in 0861584 The description for Viewer is correct: Line 2822 in 0861584 Also, the Reverse search section should be removed from Viewer: search and Editor: search replace topics, since it's no longer available: Viewer: search Lines 3073 to 3074 in 0861584 Editor: search replace Lines 3217 to 3218 in 0861584 |
|
Thank you for the feedback, @rohitab. To the point, as usual. Yeah! I completely forgot to update Help. :( This only shows how shifting into developer's midframe completely displaces technical writer's one. Doing it right now. |
|
Since you're updating the Help files, do you mind fixing another small typo in the Editor: All matching entries menu topic? I think it should be Lines 3400 to 3401 in 52b8370 |
c0a153f to
077d479
Compare
Scratch that. I looked at the code, and sure enough, you are right. Applied the change. |
|
@alabuzhev: rebased, updated help files, ready to merge. Thanks. |
… (down or up respectfully) instead of reversing the direction defined by the last invocation of the Search / Replace dialog. Also, on the dialog itself, replaced "Reverse" checkbox with "Search Down / Up" buttons.
077d479 to
b5ac955
Compare
|
Thank you |

Summary
gh-600: Shift+F7 and Alt+F7 now search in absolute directions (down or up respectfully)
instead of reversing the direction defined by the last invocation of the Search / Replace dialog.
Also, on the dialog itself, replaced "Reverse" checkbox with "Search Down / Up" buttons.
Checklist
If not checked, I accept that this work might be rejected in favor of a different great big ineffable plan.