feat: support display of rule content that is not string#118
Merged
feat: support display of rule content that is not string#118
Conversation
carlosgoias
previously approved these changes
Feb 3, 2023
carlosgoias
previously approved these changes
Feb 3, 2023
fernando-a-marins
previously approved these changes
Feb 3, 2023
033a7f1
carlosgoias
approved these changes
Feb 3, 2023
fernando-a-marins
approved these changes
Feb 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We want to be able to to support the display in the web UI of rule contents that are not strings.
For that purpose, the front-end was modified in order to correctly serialize and show RuleContent objects:
Note: if any property of the content is null, the UI will not display it.
Change checklist
Please also check the I want to contribute guidelines and make sure you have done accordingly.
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement