Skip to content

feat: support display of rule content that is not string#118

Merged
jdromeiro merged 4 commits intomasterfrom
feat/support_display_rule_content_objects
Feb 6, 2023
Merged

feat: support display of rule content that is not string#118
jdromeiro merged 4 commits intomasterfrom
feat/support_display_rule_content_objects

Conversation

@jdromeiro
Copy link
Copy Markdown
Contributor

@jdromeiro jdromeiro commented Feb 3, 2023

Description

We want to be able to to support the display in the web UI of rule contents that are not strings.

For that purpose, the front-end was modified in order to correctly serialize and show RuleContent objects:

image

Note: if any property of the content is null, the UI will not display it.

Change checklist

  • Code follows the code rules guidelines of this project
  • Commit messages follow the commit rules of this project
  • I have self-reviewed my changes before submitting this pull request
  • I have covered new/changed code with new tests and/or adjusted existent ones
  • I have made changes necessary to update the documentation accordingly

Please also check the I want to contribute guidelines and make sure you have done accordingly.

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@jdromeiro jdromeiro changed the title Support display of rule content that is not string feat: support display of rule content that is not string Feb 3, 2023
carlosgoias
carlosgoias previously approved these changes Feb 3, 2023
@jdromeiro jdromeiro linked an issue Feb 3, 2023 that may be closed by this pull request
carlosgoias
carlosgoias previously approved these changes Feb 3, 2023
@jdromeiro jdromeiro merged commit cdc0c50 into master Feb 6, 2023
@luispfgarces luispfgarces deleted the feat/support_display_rule_content_objects branch March 22, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support display of rule content that is not string

3 participants