Skip to content

Move InMemory Provider to Rules.Framework and reference projects directly#128

Merged
jdromeiro merged 6 commits intomasterfrom
feat/93/set_rulesframework_dependencies_as_project
Mar 10, 2023
Merged

Move InMemory Provider to Rules.Framework and reference projects directly#128
jdromeiro merged 6 commits intomasterfrom
feat/93/set_rulesframework_dependencies_as_project

Conversation

@jdromeiro
Copy link
Copy Markdown
Contributor

@jdromeiro jdromeiro commented Mar 6, 2023

Description

  • Reference projects within solution by project reference, instead of by package.
    This will help in further developments, as we'll not need to create multiple branches to go live with modifcations that affect both the RulesEngine and Providers. It will also force users to use versions of rulesFramework and providers that are "in agreement".
  • Move the Providers.InMemory to inside the Rules.Framework assembly (so that it now makes part of the rules.framework nuget). This way, the Rules.Framework works as a standalone nuget and the user doesn't need to install two nugets when he just wants the simplest way to use the framework.

Change checklist

  • Code follows the code rules guidelines of this project
  • Commit messages follow the commit rules of this project
  • I have self-reviewed my changes before submitting this pull request
  • I have covered new/changed code with new tests and/or adjusted existent ones
  • I have made changes necessary to update the documentation accordingly

Please also check the I want to contribute guidelines and make sure you have done accordingly.

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@jdromeiro jdromeiro linked an issue Mar 6, 2023 that may be closed by this pull request
@jdromeiro jdromeiro self-assigned this Mar 6, 2023
@jdromeiro jdromeiro changed the title Reference projects within solution by project reference Move InMemory provider to Rules.Framework and use project dependencies by reference Mar 9, 2023
@jdromeiro jdromeiro changed the title Move InMemory provider to Rules.Framework and use project dependencies by reference Move InMemory provider to Rules.Framework and reference projects directly Mar 9, 2023
@jdromeiro jdromeiro changed the title Move InMemory provider to Rules.Framework and reference projects directly Move InMemory Provider to Rules.Framework and reference projects directly Mar 9, 2023
Comment thread src/Rules.Framework/Rules.Framework.csproj Outdated
luispfgarces
luispfgarces previously approved these changes Mar 9, 2023
Copy link
Copy Markdown
Contributor

@luispfgarces luispfgarces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

carlosgoias
carlosgoias previously approved these changes Mar 9, 2023
@jdromeiro jdromeiro added dependencies Pull requests that update a dependency file enhancement New feature or request maintenance & refactoring Restructure the codebase without altering functionality and removed dependencies Pull requests that update a dependency file enhancement New feature or request labels Mar 10, 2023
@jdromeiro jdromeiro merged commit 21a02ee into master Mar 10, 2023
@luispfgarces luispfgarces deleted the feat/93/set_rulesframework_dependencies_as_project branch March 22, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance & refactoring Restructure the codebase without altering functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants