Skip to content

Remove obsolete IValueConditionNodes and WithPriority()#132

Merged
jdromeiro merged 4 commits intomasterfrom
feat/131/remove_obsolete_valueconditionnodes
Mar 21, 2023
Merged

Remove obsolete IValueConditionNodes and WithPriority()#132
jdromeiro merged 4 commits intomasterfrom
feat/131/remove_obsolete_valueconditionnodes

Conversation

@jdromeiro
Copy link
Copy Markdown
Contributor

@jdromeiro jdromeiro commented Mar 15, 2023

Description

Removes IValueConditionNodes marked as Obsolete:

  • BooleanConditionNode
  • DecimalConditionNode
  • IntegerConditionNode
  • StringConditionNode

Also removes obsolete method WithPriority().

Closes #131

Change checklist

  • Code follows the code rules guidelines of this project
  • Commit messages follow the commit rules of this project
  • I have self-reviewed my changes before submitting this pull request
  • I have covered new/changed code with new tests and/or adjusted existent ones
  • I have made changes necessary to update the documentation accordingly

Please also check the I want to contribute guidelines and make sure you have done accordingly.

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@jdromeiro jdromeiro added the maintenance & refactoring Restructure the codebase without altering functionality label Mar 15, 2023
@jdromeiro jdromeiro self-assigned this Mar 15, 2023
@jdromeiro jdromeiro requested a review from luispfgarces March 15, 2023 18:12
luispfgarces
luispfgarces previously approved these changes Mar 15, 2023
Comment thread src/Rules.Framework/Evaluation/ValueEvaluation/DeferredEval.cs Outdated
Copy link
Copy Markdown
Contributor

@luispfgarces luispfgarces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdromeiro jdromeiro changed the title Removed obsolete IValueConditionNodes Remove obsolete IValueConditionNodes and WithPriority() Mar 16, 2023
@jdromeiro jdromeiro merged commit 555ac79 into master Mar 21, 2023
@luispfgarces luispfgarces deleted the feat/131/remove_obsolete_valueconditionnodes branch March 22, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance & refactoring Restructure the codebase without altering functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove obsolete IValueConditionNode implementations

3 participants