Skip to content

refactor(TMC2130_Basics): optimize SPI flush loops #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chris0xdeadbeef wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(TMC2130_Basics): optimize SPI flush loops #168

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c5946a
refactor(TMC2130_Basics): replace magic number with constexpr and use…
Chris0xdeadbeef Sep 26, 2025
bf705df
refactor(TMC2130_Basics): use constexpr + uint8_t in SPI flush loops
Chris0xdeadbeef Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/TMC2130_Basics.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ uint8_t TMC2130_Basics::read_STAT()
_status = SPI.transfer(0x00);

// flush 4 bytes
for (int i = 0; i < 4; i++) {
constexpr uint8_t BYTES_TO_FLUSH = 4;
for (uint8_t i = 0; i < BYTES_TO_FLUSH; ++i) {
SPI.transfer(0x00);
}

Expand All @@ -54,7 +55,8 @@ uint8_t TMC2130_Basics::read_REG(uint8_t address, uint32_t *data)
_status = SPI.transfer(address&~FB_TMC_WRITE);

// flush 4 bytes
for (int i = 0; i < 4; i++) {
constexpr uint8_t BYTES_TO_FLUSH = 4;
for (uint8_t i = 0; i < BYTES_TO_FLUSH; ++i) {
SPI.transfer(0x00);
}

Expand Down