Use object.type instead of object.data to check which type it is #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
lgtm, considering it removes the need for a none check and makes the code shorter and cleaner. |
Collaborator
|
looks good, just needs conflicts fixed. |
Dragorn421
approved these changes
Dec 26, 2023
Contributor
Dragorn421
left a comment
Dragorn421
left a comment
There was a problem hiding this comment.
Things seem not broken ™️ in my crude testing.
and yeah hopefully this is straightforward enough to not break anything in the first place
Dragorn421
added
the
merge soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ngl idk how to name this PR lol, might need testing before merging to make sure everything's fine