-
Notifications
You must be signed in to change notification settings - Fork 100
[SM64] Fix combined exporter level regressions #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SM64] Fix combined exporter level regressions #405
Conversation
this was not a merge conflict, you could argue the issue with the simple level layout operator was kinda of a conflict (with settings rework which added it) but the other change was just a bug |
|
I can test tonight |
fix custom level name pathing
|
ok honestly I never used custom exports before. I don't really remember what it used to be but shouldn't this string property have a directory subtype so it isn't ass to use. In order for it to export you have to put in the full path you're using, which is kind of weird. You would expect it to branch off of the decomp path. |
|
or rather it seems like the two props are crossed all about. That should get fixed.. Path should be the path/directory. Name should be the root folder. I am honestly not a fan of this method but I believe that was the original scheme. Right now they're used wrong in the UI and for exporting. |
…decomp_level is true and changed pathing tips to be more clear
|
I have some ideas I made a PR for this instead of doing it via review |
make actors with level header use all level export
Dragorn421
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is my understanding this has been well tested by the community
The code changes look sensible
I merely tested fast64 enables correctly
Uh oh!
There was an error while loading. Please reload this page.