Skip to content

Conversation

@Lilaa3
Copy link
Collaborator

@Lilaa3 Lilaa3 commented Aug 6, 2024

  1. Non decomp relative custom levels are now exportable
  2. Custom level names no longer fail to be added to the level define macro list
  3. Export all selected mode will no longer throw errors in the ui when no object is selected
  4. Create level layout now uses the correct new prop making it functional again
  5. Fixed actor common1 script load exports not figuring out the script number correctly
  6. Fixed actor script load exports not figuring out that there is no script for the number and just trying to export to the line after the last load model command found
  7. Automatically add includes for non included group and level headers for bhv script exports
  8. Hide script load export in custom/custom group
  9. Fixed level script load exports matching object's model ID's outside fast64's model load level script
  10. Fixed level script load exports not adding a return on creating the model load script
  11. Fixed level data includes adding a new line after instead of before them, causing issues with existing files.
  12. Fixed custom always creating a new level script instead of parsing the existing one
  13. Fixed unreachable static dl code path
  14. Fixed puppycam empties (used removed property and tried to use a hardcoded scene)

@Dragorn421
Copy link
Contributor

This was caused by merging #284 right? and it didn't conflict as far as git was concerned, but there in fact were incompatible changes made to main meanwhile

any tester in chat (at random, @Reonu ?! :) )

@Lilaa3
Copy link
Collaborator Author

Lilaa3 commented Aug 7, 2024

This was caused by merging #284 right? and it didn't conflict as far as git was concerned, but there in fact were incompatible changes made to main meanwhile

any tester in chat (at random, @Reonu ?! :) )

this was not a merge conflict, you could argue the issue with the simple level layout operator was kinda of a conflict (with settings rework which added it) but the other change was just a bug

@Reonu
Copy link
Contributor

Reonu commented Aug 7, 2024

I can test tonight

@Lilaa3 Lilaa3 added the sm64 Has to do with the Super Mario 64 side label Aug 9, 2024
@Lilaa3 Lilaa3 requested a review from jesusyoshi54 August 10, 2024 14:16
@jesusyoshi54
Copy link
Collaborator

ok honestly I never used custom exports before. I don't really remember what it used to be but shouldn't this string property have a directory subtype so it isn't ass to use. In order for it to export you have to put in the full path you're using, which is kind of weird. You would expect it to branch off of the decomp path.
Also when I did the PR for fixing the name, I used custom_export_path not custom_export_name. custom_export_path is used for the actors not levels -_-
pretty cringe of me

@jesusyoshi54
Copy link
Collaborator

jesusyoshi54 commented Aug 11, 2024

or rather it seems like the two props are crossed all about. That should get fixed..

Path should be the path/directory. Name should be the root folder. I am honestly not a fan of this method but I believe that was the original scheme. Right now they're used wrong in the UI and for exporting.

@jesusyoshi54
Copy link
Collaborator

I have some ideas I made a PR for this instead of doing it via review

Copy link
Contributor

@Dragorn421 Dragorn421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is my understanding this has been well tested by the community
The code changes look sensible
I merely tested fast64 enables correctly

@Dragorn421 Dragorn421 merged commit a2afa18 into Fast-64:main Sep 4, 2024
@Lilaa3 Lilaa3 deleted the fix-combined-exporter-regressions branch May 25, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sm64 Has to do with the Super Mario 64 side

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants