[SM64] Fix SM64 binary geolayout exports #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be something wrong with reverts still, will investigate
Collaborator
Author
|
There seems to be something wrong with reverts still, will investigate before actually having up to review |
Lilaa3
force-pushed
the
fix-binary-geolayouts
branch
from
d5e18ea to
d37ce93
Compare
Collaborator
Author
|
Last commit accidentaly fixed an issue with bleed in binary! |
Collaborator
Author
|
It turns out my last issue was just from world defaults being wonky in the file I was testing, everything is fixed sorry for the wait |
Contributor
|
LET'S FUCKING GO |
Lilaa3
added
bug
jesusyoshi54
approved these changes
Dec 28, 2024
Collaborator
jesusyoshi54
left a comment
jesusyoshi54
left a comment
There was a problem hiding this comment.
exported successfully Mario in RM test ROM.
worked with and without bleed.
also exported to decomp and it still worked
jesusyoshi54
added
the
merge soon
Lilaa3
added a commit
to Lilaa3/fast64
that referenced
this pull request
Jul 9, 2025
jesusyoshi54
pushed a commit
that referenced
this pull request
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't pass in dl reference when not an object empty (need confirmation this is fine)
Update size and export binary functions for transform nodes
Check for export tag in material binary saves (fixes bleed exporting unused data)