[SM64] Add better exception processing to combined exporter #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 11, 2025 18:30
…which will give a warning in the console. Possibility to add warning for user for other exceptions though probably not
jesusyoshi54
added
enhancement
Lilaa3
approved these changes
Apr 17, 2025
Collaborator
Lilaa3
left a comment
Lilaa3
left a comment
There was a problem hiding this comment.
Only thing I can comment on is the fact that now empty collision/gfx errors will include the exc warn string in the error message reported on screen. But that doesn't make any difference to the user so this works. Feel free to change it if that bothers you.
Lilaa3
added
the
merge soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically when exporting all selected with the combined exporter, exceptions were passed over as it would be common for objects to be selected without gfx or col data and to throw an exception.
Now the exceptions I except to appear during this have an extra argument that I catch during exception processing so that I only pass them (e.g. no data type exceptions), and all other valid exceptions will halt the export