[OoT] Fixed writing to the spec file #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yanis002
added
bug
Lilaa3
requested changes
Apr 17, 2025
Collaborator
Lilaa3
left a comment
Lilaa3
left a comment
There was a problem hiding this comment.
Just a suggestion but otherwise works like a charm
Lilaa3
approved these changes
May 17, 2025
Lilaa3
added
the
merge soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently decomp changed how the spec file is handled, now there's a split for scenes and overlays (also other files that we don't care here), the
specfile at the root turned to a folder, which contains the spec file with the includes I mentioned. With this fix it should work properly for both legacy and new decomps (untested for legacy). Also there was an issue where the stuff before the first segment would be misinterpreted if it's not present (which is the case for the scene spec includes).Note: while it should work properly for normal decomp, it's still broken for HackerOoT specifically because of an
#elsein the scene table