Skip to content

Conversation

@Yanis002
Copy link
Collaborator

@Yanis002 Yanis002 commented May 29, 2025

We missed a little bug with the exporter, when you export actors without their object dependencies, Fast64 will add it automatically, except since the new exporter it was being added to the duplicated room object instead of the original room object

This is addressed by passing the original scene object to RoomEntries.new() which will fetch the original room objects to use in addMissingObjectsToAllRoomHeaders, not sure if there's a better fix but this works

@Yanis002 Yanis002 added bug Something isn't working oot Has to do with the Ocarina of Time 64 side labels May 29, 2025
@Yanis002
Copy link
Collaborator Author

additional change: I made the room object list sorted by room index instead of trusting the room name, I was concerned about weird object names causing both list not to be synced, which would be bad

@Dragorn421 Dragorn421 added this to the v2.4.0 milestone May 29, 2025
@Dragorn421 Dragorn421 added the merge soon Will be merged in a few days at most if nothing else comes up label May 29, 2025
@Dragorn421 Dragorn421 merged commit a80a05b into Fast-64:main May 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working merge soon Will be merged in a few days at most if nothing else comes up oot Has to do with the Ocarina of Time 64 side

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants