Skip to content

Fix Link import/export#552

Merged
Dragorn421 merged 6 commits intoFast-64:mainfrom
Dragorn421:fix_link_import_export
Aug 5, 2025
Merged

Fix Link import/export#552
Dragorn421 merged 6 commits intoFast-64:mainfrom
Dragorn421:fix_link_import_export

Conversation

@Dragorn421
Copy link
Contributor

@Dragorn421 Dragorn421 commented Jun 20, 2025

Fixes some issues introduced by #547 by refactoring a bunch of stuff
Also incidentally fixes removing skeletons when exporting

Help needed for fixing the import of pre-new-assets Link, I get

Traceback (most recent call last):
  File "/home/dragorn421/.var/app/org.blender.Blender/config/blender/4.4/scripts/addons/fast64_gitlinked/fast64_internal/z64/skeleton/operators.py", line 76, in execute
    ootImportSkeletonC(decompPath, importSettings)
  File "/home/dragorn421/.var/app/org.blender.Blender/config/blender/4.4/scripts/addons/fast64_gitlinked/fast64_internal/z64/skeleton/importer/functions.py", line 313, in ootImportSkeletonC
    ootGetObjectPath(isCustomImport, importPath, folderName, False),
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dragorn421/.var/app/org.blender.Blender/config/blender/4.4/scripts/addons/fast64_gitlinked/fast64_internal/z64/utility.py", line 470, in ootGetObjectPath
    ootGetPath(
  File "/home/dragorn421/.var/app/org.blender.Blender/config/blender/4.4/scripts/addons/fast64_gitlinked/fast64_internal/z64/utility.py", line 507, in ootGetPath
    raise PluginError(path + " does not exist.")
fast64_gitlinked.fast64_internal.utility.PluginError: /home/dragorn421/Documents/oot_prenewassets/./assets/objects/object_link_boy does not exist.

@Dragorn421 Dragorn421 changed the title Fix Link import/export (wip) Fix Link import/export Jun 20, 2025
@Dragorn421 Dragorn421 marked this pull request as ready for review June 20, 2025 11:54
@Dragorn421 Dragorn421 added bug Something isn't working oot Has to do with the Ocarina of Time 64 side labels Jun 23, 2025
@Yanis002
Copy link
Collaborator

oh I completely missed the ready to review, I'll do it soon 👍

Copy link
Collaborator

@Yanis002 Yanis002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adult link works fine but child link still have issues apparently:

fast64.fast64_internal.utility.PluginError: Could not find texture "/*
        Note `PLAYER_EYES_RIGHT` corresponds to the "left" eyes texture", so it can not be used in a flipbook texture.
For OOT scenes this may be because the scene's draw config references textures not stored in its scene/room files.
In this case, draw configs that use flipbook textures should only be used for one scene.

also I found a way to not hardcode the enum but it seems a bit redundant with that filepaths.extend line 311 of importer/functions.py

Copy link
Collaborator

@Yanis002 Yanis002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works but I'm concerned about that enum oddity, I just hope it won't come back later 🙏 (tested on decomp and hackeroot)

@Yanis002 Yanis002 added merge soon Will be merged in a few days at most if nothing else comes up and removed merge soon Will be merged in a few days at most if nothing else comes up labels Aug 4, 2025
@Dragorn421 Dragorn421 requested a review from Yanis002 August 4, 2025 14:13
Copy link
Collaborator

@Yanis002 Yanis002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works properly for real (except the collar but this can wait, I think fixing the import itself is more important than fixing one texture not importing properly)

@Yanis002 Yanis002 added the merge soon Will be merged in a few days at most if nothing else comes up label Aug 4, 2025
@Dragorn421 Dragorn421 merged commit 21059ce into Fast-64:main Aug 5, 2025
1 check passed
@Dragorn421 Dragorn421 deleted the fix_link_import_export branch August 5, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working merge soon Will be merged in a few days at most if nothing else comes up oot Has to do with the Ocarina of Time 64 side

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants