Merged
Conversation
Collaborator
|
oh I completely missed the ready to review, I'll do it soon 👍 |
Yanis002
requested changes
Jul 17, 2025
Collaborator
Yanis002
left a comment
There was a problem hiding this comment.
adult link works fine but child link still have issues apparently:
fast64.fast64_internal.utility.PluginError: Could not find texture "/*
Note `PLAYER_EYES_RIGHT` corresponds to the "left" eyes texture", so it can not be used in a flipbook texture.
For OOT scenes this may be because the scene's draw config references textures not stored in its scene/room files.
In this case, draw configs that use flipbook textures should only be used for one scene.
also I found a way to not hardcode the enum but it seems a bit redundant with that filepaths.extend line 311 of importer/functions.py
Yanis002
approved these changes
Aug 4, 2025
Collaborator
Yanis002
left a comment
There was a problem hiding this comment.
it works but I'm concerned about that enum oddity, I just hope it won't come back later 🙏 (tested on decomp and hackeroot)
Yanis002
approved these changes
Aug 4, 2025
Collaborator
Yanis002
left a comment
There was a problem hiding this comment.
works properly for real (except the collar but this can wait, I think fixing the import itself is more important than fixing one texture not importing properly)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some issues introduced by #547 by refactoring a bunch of stuff
Also incidentally fixes removing skeletons when exporting
Help needed for fixing the import of pre-new-assets Link, I get