[Codebase] Fix setOrigin AGAIN #588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
transform_apply was not neeeded, typehint was missing and offset was being affected by obj.location, we actually just zero it out now before applying the world matrix. also removed the temp_override cause transform already does that.
…ted original to the mesh (im stupid) add doc string instead of a comment mentioning the behavior
Lilaa3
force-pushed
the
fix-set-origin-AGAIN
branch
from
2ff2c60 to
ab51831
Compare
Lilaa3
force-pushed
the
fix-set-origin-AGAIN
branch
from
90c6b25 to
9fe0365
Compare
Lilaa3
force-pushed
the
fix-set-origin-AGAIN
branch
from
9fe0365 to
20b7773
Compare
Yanis002
approved these changes
Oct 8, 2025
Yanis002
added
the
merge soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transform_apply was not neeeded, typehint was missing and offset was being affected by obj.location, we actually just zero it out now before applying the world matrix. also removed the temp_override cause transform already does that.