Remove dev warning #940
Remove dev warning #940
Conversation
|
Download the artifacts for this pull request: |
|
Have you made sure that the tag and release workflow for Firefox doesn't interfere with my WebStoreDeploy workflow? If those 2 collide it could lead to issues with uploading it, so we should look into signing and uploading it in the same workflow to avoid interference if this is a issue. |
0xc60f
left a comment
0xc60f
left a comment
There was a problem hiding this comment.
Have you made sure that the tag and release workflow for Firefox doesn't interfere with my WebStoreDeploy workflow? If those 2 collide it could lead to issues with uploading it, so we should look into signing and uploading it in the same workflow to avoid interference if this is a issue
|
I don't think the tag and release workflow will have any conflicts with the webstore deploy one, this handles the github releases i.e. pre-release versions. We can use this workflow for beta mv3 and legacy mv2 builds and webstore deploy can be used when mv3 is ready for release. |
lostdusty
left a comment
lostdusty
left a comment
There was a problem hiding this comment.
There shouldn't be any issues.
Remove the dev warning so that users don't panic
How will we know if we're in dev mode then??
it says next to the version:
Why?
I created a tag and release workflow which releases a signed version of the extension for firefox example. I used the --channel=unlisted so mozilla signs the extension without a review. Now users are not required to use the nightly or developer version of Firefox to install the extension.
Aren't we bypassing Mozilla' safety policies then?
No, the dev mode means the injection script is packed with extension. However, the background script does periodically send a request to github for new verision but it does not use them. This has already been fixed on the mv3 branch, no point in changing the background script for a soon-to-be deprecated version
Why is the button stuck at "downloading bypass definitions..."?
Fixed (read removed entirely) on the mv3 branch, so again no point fixing it here
Checklist: