Skip to content

style: apply rustfmt to lnk pipeline files#131

Merged
zackees merged 1 commit intomainfrom
chore/rustfmt-cleanup
Apr 19, 2026
Merged

style: apply rustfmt to lnk pipeline files#131
zackees merged 1 commit intomainfrom
chore/rustfmt-cleanup

Conversation

@zackees
Copy link
Copy Markdown
Member

@zackees zackees commented Apr 19, 2026

Summary

Test plan

  • cargo fmt --check passes (these were the delta)
  • CI green across Linux / macOS / Windows

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Refactor

    • Code formatting and restructuring improvements across build orchestration and CLI modules.
  • Tests

    • Updated test code formatting and assertion structure for improved readability.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1901fc2f-a6b8-482b-b9fa-1a0070c58ff1

📥 Commits

Reviewing files that changed from the base of the PR and between 687e66e and 2615247.

📒 Files selected for processing (4)
  • crates/fbuild-build/src/esp32/orchestrator.rs
  • crates/fbuild-cli/src/main.rs
  • crates/fbuild-packages/src/lnk/embed.rs
  • crates/fbuild-packages/tests/lnk_e2e.rs

📝 Walkthrough

Walkthrough

This pull request applies formatting and code style improvements across four files in the fbuild project. Function calls, error messages, and test assertions are refactored between single-line and multi-line formats. No logic, control flow, or exported API signatures are altered.

Changes

Cohort / File(s) Summary
Production Code Formatting
crates/fbuild-build/src/esp32/orchestrator.rs, crates/fbuild-cli/src/main.rs
Reformatting of function calls (e.g., materialize_lnk_entry, resolve_root), error messages, and println! statements between single and multi-line styles. No behavioral or semantic changes.
Test Code Formatting
crates/fbuild-packages/src/lnk/embed.rs, crates/fbuild-packages/tests/lnk_e2e.rs
Simplification of test assertions and vector initializations; restructuring of test route handler closure. Test behavior and expectations remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 Formatting hops so neat and clean,
Single lines and multi-scene,
No logic changed, just styled with grace,
Readability wins the race!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'style: apply rustfmt to lnk pipeline files' accurately describes the main change—applying formatting fixes across lnk-related files using rustfmt, matching the PR's stated purpose of style/whitespace cleanup.
Docstring Coverage ✅ Passed Docstring coverage is 80.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/rustfmt-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees zackees merged commit e3b4510 into main Apr 19, 2026
7 of 77 checks passed
zackees added a commit that referenced this pull request Apr 19, 2026
Cuts a release containing the two P0 fixes landed since 2.1.19:

- #134 "P0 regression — Operation not permitted (os error 1) on warm build"
- #135 "preserve exec bit on fbuild console script in wheel"

Both are currently blocking every FastLED uno build on GitHub Actions:
the wheel's console script installs without +x, so CI can't even run
`fbuild --version`, and the subsequent compile fails with
`Operation not permitted (os error 1)` on every example.

Also includes:

- #131 rustfmt on lnk pipeline
- #133 DiskCache leases.refcount schema migration
- #128 AVR orchestrator fingerprint fast-path + telemetry (#127)
- #126 FBUILD_WATCH_SET_CACHE_SECS env override
- f8533d3 extend watch-set fingerprint fast-path to AVR orchestrator

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zackees added a commit that referenced this pull request Apr 19, 2026
Cuts a release containing the two P0 fixes landed since 2.1.19:

- #134 "P0 regression — Operation not permitted (os error 1) on warm build"
- #135 "preserve exec bit on fbuild console script in wheel"

Both are currently blocking every FastLED uno build on GitHub Actions:
the wheel's console script installs without +x, so CI can't even run
`fbuild --version`, and the subsequent compile fails with
`Operation not permitted (os error 1)` on every example.

Also includes:

- #131 rustfmt on lnk pipeline
- #133 DiskCache leases.refcount schema migration
- #128 AVR orchestrator fingerprint fast-path + telemetry (#127)
- #126 FBUILD_WATCH_SET_CACHE_SECS env override
- f8533d3 extend watch-set fingerprint fast-path to AVR orchestrator

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant