Skip to content

Fix Teensy framework library resolution#164

Merged
zackees merged 1 commit intomainfrom
fix-teensy-framework-libs
Apr 21, 2026
Merged

Fix Teensy framework library resolution#164
zackees merged 1 commit intomainfrom
fix-teensy-framework-libs

Conversation

@zackees
Copy link
Copy Markdown
Member

@zackees zackees commented Apr 21, 2026

Summary

Fixes #163.

  • Switches the Teensy framework package from the core-only PaulStoffregen/cores archive to PlatformIO's full framework-arduinoteensy package.
  • Adds Teensyduino framework library include discovery so headers like SPI.h and OctoWS2811.h are visible to Teensy builds.
  • Selects and compiles only bundled framework libraries referenced by project sources, following transitive framework includes while skipping examples/extras/tests.
  • Adds unit coverage for Teensy framework library resolution and an ignored integration build that includes SPI.h and OctoWS2811.h.

Verification

  • cargo test -p fbuild-packages library::teensy_core
  • cargo test -p fbuild-build teensy::orchestrator
  • cargo test -p fbuild-build --test teensy_build build_teensy41_blink -- --ignored --nocapture
  • cargo test -p fbuild-build --test teensy_build build_teensy41_spi_octo_headers -- --ignored --nocapture

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

Warning

Rate limit exceeded

@zackees has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 30 minutes and 24 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 30 minutes and 24 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 058a81db-ce15-4d6c-8ff4-55b2fbfc57a8

📥 Commits

Reviewing files that changed from the base of the PR and between d7a215a and a9fc8a8.

📒 Files selected for processing (4)
  • crates/fbuild-build/src/teensy/orchestrator.rs
  • crates/fbuild-build/tests/teensy_build.rs
  • crates/fbuild-packages/src/library/mod.rs
  • crates/fbuild-packages/src/library/teensy_core.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-teensy-framework-libs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees zackees merged commit 56f21c8 into main Apr 21, 2026
74 of 77 checks passed
zackees added a commit that referenced this pull request Apr 24, 2026
…e, ...) (#203)

The STM32 orchestrator installs the STM32duino core but never walked
libraries/*/ to surface bundled libraries to sketches. Any sketch that
transitively included <SPI.h> (e.g. FastLED's STM32 fastspi path) failed
with "fatal error: SPI.h: No such file or directory" despite SPI living
right there in the cache.

Mirror PR #164's Teensy fix:

- Add a shared FrameworkLibrary model + discover_framework_libraries()
  walker in fbuild-packages, used by both TeensyCores and Stm32Cores.
- Extract the #include-scanning / transitive-closure resolver out of the
  Teensy orchestrator into crate::framework_libs so both platforms share
  one code path.
- Wire Stm32Cores::get_framework_libraries() +
  get_framework_library_include_dirs() into the STM32 orchestrator after
  SrcWrapper so the resolver picks up SPI/Wire/EEPROM/... on demand and
  their include dirs reach the sketch compile command.

Fixes #202

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Teensy 4.x builds miss framework libraries like SPI and OctoWS2811

1 participant